-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KubeVirt platform artifact and image information #41
Conversation
4701eed
to
2243d7b
Compare
/cc @davidvossel |
2243d7b
to
8072207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
8072207
to
d549d85
Compare
Artifact: KubeVirt containerDisks have a normal qcow2 image as base, similar configured like for OpenStack. Image: KubeVirt consumes directly a qcow2 disk inside a container which is described in the images section. It is based on the qcow2 from the base artifacts for kubevirt. Signed-off-by: Roman Mohr <rmohr@redhat.com>
d549d85
to
f5e41e9
Compare
@cgwalters thanks for the reviews! Do you know when a new release tag will be created? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits. @rmohr, if you can do a quick followup PR, I'll tag a release afterward.
Followup in #42. |
Artifact: KubeVirt containerDisks have a normal qcow2 image as base,
similar configured like for OpenStack.
Image: KubeVirt consumes directly a qcow2 disk inside a container which
is described in the images section. It is based on the qcow2 from the
base artifacts for kubevirt.
This schema extension is needed to include informations about containerDisks created in coreos/coreos-assembler#2750.
HyperShift uses this information in
rhcos.json
to determine which rhcos image to pull for the KubeVirt platform (similart to what it does for AWS).The final image information looks like this:
Building the intaller with this version and a corresponding rhcos.json give the expected results:
and